Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dctr fixes #3337

Merged
merged 2 commits into from
Dec 7, 2018
Merged

Dctr fixes #3337

merged 2 commits into from
Dec 7, 2018

Conversation

pm-manasi-moghe
Copy link
Contributor

Type of change

  • [x ] Bugfix
  • [x ] Other

Description of change

  • Do not show dctr warning message if it is not configured in any ad unit.
  • Added description regarding usage of dctr and currency params in .md file

Copy link
Contributor

@mike-chowla mike-chowla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mike-chowla mike-chowla merged commit 13182f7 into prebid:master Dec 7, 2018
loic-talon pushed a commit to onfocusio/Prebid.js that referenced this pull request Dec 19, 2018
* changes to not show dctr message when none of the adunits have dctr set

* added usage description for dctr and currency params
ghost pushed a commit to devunrulymedia/Prebid.js that referenced this pull request Jan 30, 2019
* changes to not show dctr message when none of the adunits have dctr set

* added usage description for dctr and currency params
pedrolopezmrf pushed a commit to Marfeel/Prebid.js that referenced this pull request Mar 18, 2019
* changes to not show dctr message when none of the adunits have dctr set

* added usage description for dctr and currency params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants